Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure new outputs have correct mapOver state #11683

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 19, 2021

by storing the effective mapOver state on the node.

What did you do?

  • Maintain map over status on the node and apply it when adding new outputs (via conditionals, repeats or filter)

Why did you make this change?

Fixes #10778

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    Create workflows with varying levels of mapping over, and verify that adding outputs through tool options results in the correct noodle type

For UI Components

  • I've included a screenshot of the changes

by storing the effective mapOver state on the node.
Fixes galaxyproject#10778
@mvdbeek mvdbeek marked this pull request as ready for review April 7, 2021 13:08
@mvdbeek mvdbeek added this to the 21.05 milestone Apr 7, 2021
@jmchilton jmchilton merged commit a28c9a3 into galaxyproject:dev Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency for "batch" workflow connections for optional outputs
2 participants