Break up dynamic dataset collection into chunks #11697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
split_discovery_into_chunks
branch
from
191625d
to
2989ce3
Compare
|
The sequential HID thing is a problem for newer users and smaller workflows - I think at this scale it doesn't really matter or even if it does matter scaling up is more important. |
mvdbeek
force-pushed
the
split_discovery_into_chunks
branch
from
2989ce3
to
f652c4a
Compare
Addresses galaxyproject#11488. One drawback here is that if multiple jobs are concurrently creating datasets in a history the HID is not guaranteed to be sequential between chunks. We can address this, but this is also a problem when breaking workflow executions at ``maximum_workflow_jobs_per_scheduling_iteration``. If we consider this to be a problem (personally I don't think it is, but I could be convinved otherwise) I would work on this in a different PR. On the upside the history panel will display an increasing amount of datasets created during the dataset discovery.
Which breaks down for nested collections ...
If we break between forward and reverse read we would fail validation. I guess if we want to do validation we should do that at a level before building the collection ?
mvdbeek
force-pushed
the
split_discovery_into_chunks
branch
from
968cba0
to
88074d5
Compare
And remove unused method set_collection_elements method in DatasetCollectionManager
mvdbeek
force-pushed
the
split_discovery_into_chunks
branch
from
f505e94
to
98f49a8
Compare
```
In [1]: from galaxy.util.oset import OrderedSet
In [2]: d = {1: 2, 3:4, 5:6, 0:1}
In [3]: d.keys() - {3, 5}
Out[3]: {0, 1}
In [4]: OrderedSet(d.keys()) - {3, 5}
Out[4]: OrderedSet([1, 0])
```
The dictionary's dict_keys object does not behave like a ordered set.
|
Thanks! |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One drawback here is that if multiple jobs are concurrently creating datasets in a history the HID is not guaranteed to be sequential between chunks. We can address this, but this is also a problem when breaking workflow executions at
maximum_workflow_jobs_per_scheduling_iteration.If we consider this to be a problem (personally I don't think it is, but I could be convinced otherwise) I would work on this in a different PR.
On the upside the history panel will display an increasing amount of datasets created during the dataset discovery.
What did you do?
Why did you make this change?
Addresses #11488.
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)