-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add circus + gunicorn option when using run.sh #11772
Conversation
bb1bfb0
to
180c5bc
Compare
If we want to make this the default we would also need to deprecate Python 3.6 or conditionally run uwsgi if python is < 3.7. Since we haven't really used circus/celery/fastAPI in production yet this might come too early, and we probably only want to add extra effort for our deployers once (upgrade Python, figure out how they want to run Galaxy, maybe switch to installed Galaxy that @natefoo is working on, figure out mule-less job scheduling if they had been using mules). Nothing stops us from setting up test and main to use circus/celery/fastAPI on test and main without this, so I'm just going to add an additional option so devs/users/deployers can try the new stack easily. |
If this is too short gunicorn will restart the worker before they finish booting.
We know this is running from source, so this seems like the most explicit way of finding relative config files if they're not specified. Also fixes a bug if GALAXY_CONFIG_FILE is set to no value.
So, the standard version of Python 3 on EL8 is 3.6. If the new stack is only supported on 3.7+ that's kind of a bummer, but we can make do. I have a miniconda Ansible role that makes getting a newer Python installed pretty trivial for production deployments. |
Regardless of Python 3.6 vs 3.7 issues - I generally like the idea of adding functionality and removing old defaults in separate PRs. So I prefer this approach of just working on the new dev stack here. Also it takes the pressure off of removing paste for tool shed and such. |
This PR was merged without a "kind/" label, please correct. |
What did you do?
Dropped paster supportAPP_WEBSERVER=dev ./run.sh
CIRCUS_CONFIG_FILE=<path_to_circus_config>
Lot's of work left to do still.
--daemon
Why did you make this change?
Implements #10885
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)
For UI Components