Handle deprecated postgresql db urls; update postgres version in ci #11790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was deprecated in SQLAlchemy 1.3, removed in SQLAlchemy 1.4 https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b sqlalchemy/sqlalchemy#4643
jdavcs
added
kind/enhancement
area/database
jdavcs
changed the title
nsoranzo
approved these changes
Apr 5, 2021
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
|
Thank you, @nsoranzo! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
postgresqlinstead ofpostgres(deprecated in SQLAlchemy 1.3, removed in 1.4)Why did you make this change?
With the move to SQLAlchemy 1.4,
database_connectionvalues of the oldpostgres://form will fail.Ref: https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b
Updating the pin in github workflows from 11 to 13 is related cleanup.
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)