Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.01] Lower tool id case while populating resource params #11793

Merged
merged 1 commit into from
Apr 7, 2021
Merged

[20.01] Lower tool id case while populating resource params #11793

merged 1 commit into from
Apr 7, 2021

Conversation

eancelet
Copy link
Contributor

@eancelet eancelet commented Apr 6, 2021

What did you do?

On startup, when Galaxy populates the tool form with resources, the tool id is now converted to lowercase letters to match what is done on job_conf file parsing.

Why did you make this change?

It was impossible to add resources to a tool with uppercase letters in the id.
#11709

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@mvdbeek mvdbeek changed the title Lower tool id case while populating resource params [21.01] Lower tool id case while populating resource params Apr 7, 2021
@mvdbeek
Copy link
Member

mvdbeek commented Apr 7, 2021

I've run the tests against dev and they're all passing. Thanks again @eancelet!

@mvdbeek mvdbeek added this to the 21.05 milestone Apr 7, 2021
@mvdbeek mvdbeek merged commit 93d19df into galaxyproject:release_20.01 Apr 7, 2021
@mvdbeek mvdbeek changed the title [21.01] Lower tool id case while populating resource params [20.01] Lower tool id case while populating resource params Apr 7, 2021
@eancelet
Copy link
Contributor Author

eancelet commented Apr 7, 2021

Thank you @mvdbeek. I didn't know what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants