Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Also check for boolean True, not just string 'True' when evaluating conditional dependencies. #11861

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

rhpvorderman
Copy link
Contributor

@rhpvorderman rhpvorderman commented Apr 19, 2021

What did you do?

  • Accept True as a boolean true in the conditional dependencies script. Strangely enough it only checked for 'true' and 'True' not actual True. EDIT: I think this might be because the old INI config does not support literal booleans.

Why did you make this change?

When people know how actual yaml works they might have

galaxy:
    watch_tools: true

as their config. Which signifies an actual Boolean value. This should be considered by the script as well.

Can this be backported to all supported releases? On a production setup with ansible-galaxy and nginx this leads to quite annoying errors: "502 Bad gateway" in NGINX. Which prompts debugging, checking the logs and then finding out watchdogs is not installed while it should be.

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

For UI Components

  • I've included a screenshot of the changes

…onditional dependencies.

When people know how actual yaml works they might have

    galaxy:
        watch_tools: true

as their config. Which signifies an actual Boolean value. This should be considered by the script as well.
@github-actions github-actions bot added this to the 21.05 milestone Apr 19, 2021
@rhpvorderman rhpvorderman changed the title Also check for boolean True, not just string 'True' when evaluating conditional dependencies. BUGFIX: Also check for boolean True, not just string 'True' when evaluating conditional dependencies. Apr 19, 2021
@jmchilton jmchilton merged commit 5c6b738 into galaxyproject:dev Apr 19, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants