BUGFIX: Also check for boolean True, not just string 'True' when evaluating conditional dependencies. #11861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
True
as a boolean true in the conditional dependencies script. Strangely enough it only checked for'true'
and'True'
not actualTrue
. EDIT: I think this might be because the old INI config does not support literal booleans.Why did you make this change?
When people know how actual yaml works they might have
as their config. Which signifies an actual Boolean value. This should be considered by the script as well.
Can this be backported to all supported releases? On a production setup with ansible-galaxy and nginx this leads to quite annoying errors: "502 Bad gateway" in NGINX. Which prompts debugging, checking the logs and then finding out watchdogs is not installed while it should be.
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)
License
For UI Components