Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.05] Fix select all in import from history backbone modal #12082

Merged
merged 1 commit into from
Jun 1, 2021
Merged

[21.05] Fix select all in import from history backbone modal #12082

merged 1 commit into from
Jun 1, 2021

Conversation

OlegZharkov
Copy link
Contributor

@OlegZharkov OlegZharkov commented May 31, 2021 •
edited
Loading

Select button in backbone modal wasn't working. Somehow selectAll function was lost during transition.
Fixes #12006

How to test the changes?

  • Instructions for manual testing are as follows:
    1. try to import all your datasets from history to the library folder

image

License

@OlegZharkov OlegZharkov changed the base branch from dev to release_21.05 May 31, 2021 17:03
@github-actions github-actions bot added this to the 21.09 milestone May 31, 2021
@OlegZharkov OlegZharkov modified the milestones: 21.09, 21.05 May 31, 2021
@jmchilton jmchilton merged commit 99048b6 into galaxyproject:release_21.05 Jun 1, 2021
@OlegZharkov OlegZharkov deleted the select_all_backbone_modal branch June 1, 2021 15:17
@OlegZharkov
Copy link
Contributor Author

thanks @jmchilton!

@OlegZharkov OlegZharkov mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/libraries Data libraries area/UI-UX kind/bug
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

Libraries: the select all checkbox when adding datasets to a library from history doesn't behave as expected
2 participants
@OlegZharkov @jmchilton