Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] Fix copying text in workflow editor #12118

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 9, 2021

The only text we could copy had to be within input boxes, but we may
want to also copy text from the error / upgrade message modal or from
the help text or other links.
So if there's currently any highlighted text we skip the workflow copy
logic.
Copying nodes continues to work correctly, one only needs to make sure we're not currently highlighting text or that we're within a input element.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    Open a workflow and highlight any tool help text or tool label, and paste it into another window.

License

The only text we could copy had to be within input boxes, but we may
want to also copy text from the error / upgrade message modal or from
the help text or other links.
So if there's currently any highlighted text we skip the workflow copy
logic.
@github-actions github-actions bot added this to the 21.09 milestone Jun 9, 2021
@mvdbeek mvdbeek modified the milestones: 21.09, 21.05 Jun 10, 2021
@jmchilton jmchilton merged commit 747c8a8 into galaxyproject:release_21.05 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants