Users API: add the update endpoint #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds deserialization method for usernames (note: still needs trans) - Adds tests for deserializer in test_UserManager.py
- users and admin can now update usernames via the API - adds api tests to update
| from galaxy.managers import histories, users | ||
|
|
||
| from .base import BaseTestCase | ||
| from base import BaseTestCase |
There was a problem hiding this comment.
Please revert to include the dot (for Python3).
|
👍 |
| @@ -736,7 +736,7 @@ class ModelDeserializer( HasAModelManager ): | |||
| """ | |||
| # TODO:?? a larger question is: which should be first? Deserialize then validate - or - validate then deserialize? | |||
|
|
|||
| def __init__( self, app, **kwargs ): | |||
| def __init__( self, app, validator=None, **kwargs ): | |||
There was a problem hiding this comment.
The new validator parameter does not seem to be used, is it for future functionalities?
There was a problem hiding this comment.
Future composition:
https://github.com/galaxyproject/galaxy/pull/2595/files#diff-d9bd7857711700c7d77c35956699096dR306
Up to this point ModelValidator was enough.
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements update for the users API. Currently only username is deserialized but it should be easier to add more now.
The user deserializer could be improved in the future by bypassing
validate_user_inputand removing the need to passtransfor the session.Should close: #1992