Committing format changes to the user impersonation dropdown. #2612
Conversation
|
@sszakony would love to see it larger. As for emails, a better solution here might be to re-use the existing sharing component. I'm happy to PR your PR if you would like, with this addition. |
|
@erasche my hesitation there would be that the sharing component is multi-select, which wouldn't be desirable in a user impersonation dialog. Possible I'm missing your meaning, this is my first effort at contributing here and so I beg your patience if that's the case. |
|
@sszakony congrats on your first PR :) You are correct that the sharing component is multi-select, but that is easily disabled. |
|
Actually, @sszakony wait, I for some reason thought this was in mako, but it is clear you're using the same api as the other select, which is the important bit. In that case I'm perfectly happy with this. No changes needed. 👍 |
|
@galaxybot test this |
|
Thanks again @sszakony |
The user impersonation dropdown is a) very narrow, and hard to read as a result, and b) contains only email addresses, which can be confusing if you don't know how the user you wish to impersonate signed up. Often a user will email from an account other than the one used to register for Galaxy. Also, our system uses LDAP identification, which means that the emails won't match in any case.
I propose changing the width of the dropdown to be 33% of the area width, and adding the user name to the dropdown so that it's easier to identify the user one wishes to impersonate. This required two minor changes to the impersonate.mako file. I've tested this thoroughly on my development system and have encountered no problems.