Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing format changes to the user impersonation dropdown. #2612

Merged
merged 1 commit into from Jul 13, 2016

Conversation

Projects
None yet
3 participants
@sszakony
Copy link
Contributor

commented Jul 13, 2016

The user impersonation dropdown is a) very narrow, and hard to read as a result, and b) contains only email addresses, which can be confusing if you don't know how the user you wish to impersonate signed up. Often a user will email from an account other than the one used to register for Galaxy. Also, our system uses LDAP identification, which means that the emails won't match in any case.

I propose changing the width of the dropdown to be 33% of the area width, and adding the user name to the dropdown so that it's easier to identify the user one wishes to impersonate. This required two minor changes to the impersonate.mako file. I've tested this thoroughly on my development system and have encountered no problems.

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

@sszakony would love to see it larger.

As for emails, a better solution here might be to re-use the existing sharing component.

$("#email_select").select2({

I'm happy to PR your PR if you would like, with this addition.

@sszakony

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2016

@erasche my hesitation there would be that the sharing component is multi-select, which wouldn't be desirable in a user impersonation dialog. Possible I'm missing your meaning, this is my first effort at contributing here and so I beg your patience if that's the case.

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

@sszakony congrats on your first PR :)
I'm strongly in favour of this PR in idea, just want to work through possible implementation things first.

You are correct that the sharing component is multi-select, but that is easily disabled.

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

Actually, @sszakony wait, I for some reason thought this was in mako, but it is clear you're using the same api as the other select, which is the important bit. In that case I'm perfectly happy with this. No changes needed.

👍

@erasche

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

@galaxybot test this

@erasche erasche merged commit 7bbe0a2 into galaxyproject:dev Jul 13, 2016

4 checks passed

api test Build finished. 220 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 110 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 582 tests run, 0 skipped, 0 failed.
Details
@erasche

This comment has been minimized.

Copy link
Member

commented Jul 13, 2016

Thanks again @sszakony

@martenson martenson modified the milestones: 16.07, 16.10 Jul 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.