Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.04] Workflow SVG generation fix #2628

Merged

Conversation

Projects
None yet
3 participants
@dannon
Copy link
Member

commented Jul 19, 2016

Paste handles encoding automatically when thrown unicode, but uwsgi does
not. This was resulting in unencoded (unicode) workflow drawings (svg)
not appearing at all when the gen_image was invoked. Also took the
opportunity to add a correct header for a standalone svg document.

This resolves the core issue in #2465

Paste handles encoding automatically when thrown unicode, but uwsgi does
not.  This was resulting in unencoded (unicode) workflow drawings (svg)
not appearing at all when the gen_image was invoked.  Also took the
opportunity to add a correct header for a standalone svg document.

@dannon dannon changed the title Workflow SVG generation fix [16.04] Workflow SVG generation fix Jul 19, 2016

@dannon

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2016

Followup: Will tinker to see if in the base framework we should detect/encode unicode on the fly when using uwsgi.

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 19, 2016

nice find @dannon !

@jmchilton

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

👍 , @martenson does that qualify as a +1 also?

@martenson

This comment has been minimized.

Copy link
Member

commented Jul 21, 2016

@jmchilton I cannot test locally as I do not have uwsgi setup, but I trust Dannon.

@martenson martenson merged commit 68a6418 into galaxyproject:release_16.04 Jul 21, 2016

2 of 4 checks passed

api test Build finished. 211 tests run, 0 skipped, 1 failed.
Details
toolshed test Build finished. 589 tests run, 0 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 106 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 16.07 milestone Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.