[16.04] Workflow SVG generation fix #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not. This was resulting in unencoded (unicode) workflow drawings (svg) not appearing at all when the gen_image was invoked. Also took the opportunity to add a correct header for a standalone svg document.
dannon
changed the title
|
Followup: Will tinker to see if in the base framework we should detect/encode unicode on the fly when using uwsgi. |
|
nice find @dannon ! |
|
👍 , @martenson does that qualify as a +1 also? |
|
@jmchilton I cannot test locally as I do not have uwsgi setup, but I trust Dannon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paste handles encoding automatically when thrown unicode, but uwsgi does
not. This was resulting in unencoded (unicode) workflow drawings (svg)
not appearing at all when the gen_image was invoked. Also took the
opportunity to add a correct header for a standalone svg document.
This resolves the core issue in #2465