Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid step duplication when ordering steps on the fly #3590

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Feb 10, 2017

If steps are ordered twice to identify cycles without relying on the previously stored has_cycles flag, workflow steps are duplicated. This PR prevents this duplication and makes it safe to call the cyclic test mulitple times if necessary. To test this load the run workflow form with and without this fix.

@guerler guerler added this to the 17.05 milestone Feb 10, 2017

@guerler guerler added status/review and removed status/WIP labels Feb 10, 2017

@jmchilton jmchilton merged commit d382537 into galaxyproject:dev Feb 13, 2017

5 checks passed

api test Build finished. 263 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 138 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 24 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 580 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.