Followup to exception refactoring #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with my semiautomatic refactorings.
dannon
added
kind/refactoring
nsoranzo
requested changes
Apr 24, 2017
| @@ -607,7 +607,7 @@ def traverse( folder ): | |||
| log.exception( "Unable to create archive for download" ) | |||
| raise exceptions.InternalServerError( "Unable to create archive for download." ) | |||
| except Exception: | |||
| log.exception( "Unexpected error %s in create archive for download", sys.exc_info()[ 0 ] ) | |||
| log.exception( "Unexpected error %s in create archive for download" ) | |||
There was a problem hiding this comment.
Yeah, one more commit coming. sys is also unused now.
| @@ -1863,7 +1863,7 @@ def __str__( self ): | |||
| status = 'error' | |||
| except: | |||
| error = True | |||
| log.exception( "Unexpected error %s in create archive for download", sys.exc_info()[0] ) | |||
| log.exception( "Unexpected error %s in create archive for download" ) | |||
|
xref #3933 |
nsoranzo
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues @nsoranzo noticed with my semiautomatic refactorings.