Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to exception refactoring #3959

Merged
merged 2 commits into from Apr 24, 2017

Conversation

Projects
None yet
4 participants
@dannon
Copy link
Member

commented Apr 24, 2017

Fixes a few issues @nsoranzo noticed with my semiautomatic refactorings.

Followup to exception refactoring, fixes a few issues @nsoranzo notic…
…ed with my semiautomatic refactorings.
@@ -607,7 +607,7 @@ def traverse( folder ):
log.exception( "Unable to create archive for download" )
raise exceptions.InternalServerError( "Unable to create archive for download." )
except Exception:
log.exception( "Unexpected error %s in create archive for download", sys.exc_info()[ 0 ] )
log.exception( "Unexpected error %s in create archive for download" )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 24, 2017

Member

Need to remove %s too.

This comment has been minimized.

Copy link
@dannon

dannon Apr 24, 2017

Author Member

Yeah, one more commit coming. sys is also unused now.

@@ -1863,7 +1863,7 @@ def __str__( self ):
status = 'error'
except:
error = True
log.exception( "Unexpected error %s in create archive for download", sys.exc_info()[0] )
log.exception( "Unexpected error %s in create archive for download" )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 24, 2017

Member

Same here.

@dannon

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2017

xref #3933

@galaxybot galaxybot added this to the 17.05 milestone Apr 24, 2017

@jmchilton jmchilton merged commit aa024f6 into galaxyproject:dev Apr 24, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished. 274 tests run, 0 skipped, 0 failed.
Details
framework test Build finished. 148 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 34 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.