[17.05] fix plugin access path #4152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same change is required for "tool_list" and "trans_object" webhooks as well
has extra slash before "api". Galaxy.root accounts for it. In "PhdComics", it looks fine |
|
This happens because #4065 was not properly tested. Also please note that we do not create feature branches in this repo. I will create a fix for all the webhooks shortly, thanks for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dannon @guerler without this fix the webhook is not working. There are other plugins that needs the same fix, I'm just wondering why this happens now and if there is something more serious broken.