Allow users to upload multiple FTP files within a single request #4513
Conversation
guerler
changed the title
|
Do I need to do something else than checkout |
|
@martenson thats the correct branch, we embedded the performance improvements into the regular uploader and removed the ftp tab. You could test the performance differences by selecting many ftp files in the regular view and then by clicking on start with and without this PR. However the multifile submission with differing dbkey/datatypes is still in the works. |
|
That means we are still stuck with the popover-over-modal view into FTP directory. I think we need to improve on this to use actual tree-based folder browser. (And maybe move the whole upload view into mid pane instead of a modal to give it more of a canvas.) Nevertheless this PR does not seem to be working for me. Nothing gets imported to history.
|
|
@martenson as I mentioned |
|
@guerler I selected 4 FTP files and nothing got imported into history. All have |
|
@martenson that is correct the submission to the backend has to be added. I let you know when we added it. |
|
Requires #4563. |
Conflicts: static/scripts/bundled/libs.bundled.js static/scripts/bundled/libs.bundled.js.map
|
Very nice - thanks for this! |
|
Thank you. Thanks a lot for #4563 and your overall help with this. |
This PR adds another tab to the uploader view which allows users to submit multiple FTP files at once. In contrast to the regular upload view, this option does not allow the selection of individual datatypes or genome builds per ftp file. All ftp files are submitted using the same datatype/genome specification. However, the advantage is that all FTP files can be submitted to the upload tool at once, which improves the performance for large sets. Fixes #4347 and #1090.