New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for new .txt, .md test outputs #327

Merged
merged 2 commits into from Oct 15, 2015

Conversation

Projects
None yet
5 participants
@erasche
Copy link
Member

erasche commented Oct 15, 2015

No description provided.

@erasche erasche added the bug label Oct 15, 2015

@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented Oct 15, 2015

Does it make sense to add these to .gitignore as well?

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Oct 15, 2015

@peterjc yep, they shouldn't be included in your repository. Or did you mean a gitignore as part of planemo that I'm not aware of?

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Oct 15, 2015

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Oct 15, 2015

Done

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Oct 15, 2015

👍

@peterjc

This comment has been minimized.

Copy link
Contributor

peterjc commented Oct 15, 2015

Yes, that's what I had in mind with .gitignore - I do sometimes run planemo from the repository using relative or absolute paths to my tool repositories.

+1 on merging assuming the tests come back fine.

jmchilton added a commit that referenced this pull request Oct 15, 2015

Merge pull request #327 from galaxyproject/missing-filters
Account for new .txt, .md test outputs

@jmchilton jmchilton merged commit 6c0dc20 into master Oct 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmchilton jmchilton deleted the missing-filters branch Oct 15, 2015

@jmchilton jmchilton referenced this pull request Oct 15, 2015

Open

Test Planemo Bus Factor #329

0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment