Cloud Runner Develop - 1.0 R.C 1 #437

frostebite · 2022-09-17T01:14:06Z

All 1.0 feature tasks here:

https://github.com/orgs/game-ci/projects/5/views/1

Some noteworthy improvements and refactorings

Moved all Cloud Runner "Input" to CloudRunnerOptions
garbage collection improvements
testing improvements
cloud runner pipeline improvements
retained workspace mode
local-docker provider for cloud runner (enables massively expedited.... and cheaper... testing of the pipeline to catch early failures)
General cleanup and refactoring of Cloud Runner static state
Improved method of synchronizing build parameters in a readable way into Cloud Runner jobs
GitHub Input state collected in new GitHub file

Checklist

Read the contribution guide and accept the code of conduct
Readme (updated or not needed)
Tests (added, updated or not needed)

github-actions · 2022-09-17T01:14:17Z

codecov-commenter · 2022-09-28T02:39:56Z

Codecov Report

Merging #437 (11437be) into main (9f79830) will decrease coverage by 15.65%.
The diff coverage is 27.00%.

@@             Coverage Diff             @@
##             main     #437       +/-   ##
===========================================
- Coverage   52.52%   36.87%   -15.66%     
===========================================
  Files          66       72        +6     
  Lines        2056     2693      +637     
  Branches      353      500      +147     
===========================================
- Hits         1080      993       -87     
- Misses        972     1698      +726     
+ Partials        4        2        -2

Impacted Files	Coverage Δ
src/model/cloud-runner/error/cloud-runner-error.ts	`44.44% <0.00%> (-5.56%)`	⬇️
src/model/cloud-runner/providers/aws/aws-error.ts	`36.36% <0.00%> (ø)`
.../model/cloud-runner/providers/aws/aws-job-stack.ts	`10.00% <0.00%> (-0.21%)`	⬇️
.../aws/cloud-formations/task-definition-formation.ts	`100.00% <ø> (ø)`
src/model/cloud-runner/providers/local/index.ts	`13.63% <0.00%> (-86.37%)`	⬇️
src/model/cloud-runner/providers/test/index.ts	`9.09% <0.00%> (-90.91%)`	⬇️
src/model/cloud-runner/remote-client/caching.ts	`15.62% <0.00%> (-46.88%)`	⬇️
...model/cloud-runner/services/cloud-runner-system.ts	`7.89% <0.00%> (-78.78%)`	⬇️
...cloud-runner/services/follow-log-stream-service.ts	`18.51% <0.00%> (+0.66%)`	⬆️
...loud-runner/workflows/workflow-composition-root.ts	`45.45% <0.00%> (-41.22%)`	⬇️
... and 49 more

src/model/image-tag.ts

frostebite · 2022-09-28T11:14:36Z

Be aware, there are a few redundant new files that are stubbing new behaviour and a couple of commented lines.

I'd prefer to keep these on this occasion as it will make the 1.0 release lighter and easier. And will include resolutions for those loose ends.

… collect

webbertakken · 2022-11-07T20:31:32Z

.github/workflows/build-tests.yml

-  UNITY_LICENSE: "<?xml version=\"1.0\" encoding=\"UTF-8\"?><root>\n    <License id=\"Terms\">\n        <MachineBindings>\n            <Binding Key=\"1\" Value=\"576562626572264761624c65526f7578\"/>\n            <Binding Key=\"2\" Value=\"576562626572264761624c65526f7578\"/>\n        </MachineBindings>\n        <MachineID Value=\"D7nTUnjNAmtsUMcnoyrqkgIbYdM=\"/>\n        <SerialHash Value=\"2033b8ac3e6faa3742ca9f0bfae44d18f2a96b80\"/>\n        <Features>\n            <Feature Value=\"33\"/>\n            <Feature Value=\"1\"/>\n            <Feature Value=\"12\"/>\n            <Feature Value=\"2\"/>\n            <Feature Value=\"24\"/>\n            <Feature Value=\"3\"/>\n            <Feature Value=\"36\"/>\n            <Feature Value=\"17\"/>\n            <Feature Value=\"19\"/>\n            <Feature Value=\"62\"/>\n        </Features>\n        <DeveloperData Value=\"AQAAAEY0LUJHUlgtWEQ0RS1aQ1dWLUM1SlctR0RIQg==\"/>\n        <SerialMasked Value=\"F4-BGRX-XD4E-ZCWV-C5JW-XXXX\"/>\n        <StartDate Value=\"2021-02-08T00:00:00\"/>\n        <UpdateDate Value=\"2021-02-09T00:34:57\"/>\n        <InitialActivationDate Value=\"2021-02-08T00:34:56\"/>\n        <LicenseVersion Value=\"6.x\"/>\n        <ClientProvidedVersion Value=\"2018.4.30f1\"/>\n        <AlwaysOnline Value=\"false\"/>\n        <Entitlements>\n            <Entitlement Ns=\"unity_editor\" Tag=\"UnityPersonal\" Type=\"EDITOR\" ValidTo=\"9999-12-31T00:00:00\"/>\n            <Entitlement Ns=\"unity_editor\" Tag=\"DarkSkin\" Type=\"EDITOR_FEATURE\" ValidTo=\"9999-12-31T00:00:00\"/>\n        </Entitlements>\n    </License>\n<Signature xmlns=\"http://www.w3.org/2000/09/xmldsig#\"><SignedInfo><CanonicalizationMethod Algorithm=\"http://www.w3.org/TR/2001/REC-xml-c14n-20010315#WithComments\"/><SignatureMethod Algorithm=\"http://www.w3.org/2000/09/xmldsig#rsa-sha1\"/><Reference URI=\"#Terms\"><Transforms><Transform Algorithm=\"http://www.w3.org/2000/09/xmldsig#enveloped-signature\"/></Transforms><DigestMethod Algorithm=\"http://www.w3.org/2000/09/xmldsig#sha1\"/><DigestValue>m0Db8UK+ktnOLJBtHybkfetpcKo=</DigestValue></Reference></SignedInfo><SignatureValue>o/pUbSQAukz7+ZYAWhnA0AJbIlyyCPL7bKVEM2lVqbrXt7cyey+umkCXamuOgsWPVUKBMkXtMH8L\n5etLmD0getWIhTGhzOnDCk+gtIPfL4jMo9tkEuOCROQAXCci23VFscKcrkB+3X6h4wEOtA2APhOY\nB+wvC794o8/82ffjP79aVAi57rp3Wmzx+9pe9yMwoJuljAy2sc2tIMgdQGWVmOGBpQm3JqsidyzI\nJWG2kjnc7pDXK9pwYzXoKiqUqqrut90d+kQqRyv7MSZXR50HFqD/LI69h68b7P8Bjo3bPXOhNXGR\n9YCoemH6EkfCJxp2gIjzjWW+l2Hj2EsFQi8YXw==</SignatureValue></Signature></root>"
+  UNITY_LICENSE:
+    "<?xml version=\"1.0\" encoding=\"UTF-8\"?><root>\n    <License
+    id=\"Terms\">\n        <MachineBindings>\n            <Binding Key=\"1\"
+    Value=\"576562626572264761624c65526f7578\"/>\n            <Binding Key=\"2\"
+    Value=\"576562626572264761624c65526f7578\"/>\n        </MachineBindings>\n        <MachineID
+    Value=\"D7nTUnjNAmtsUMcnoyrqkgIbYdM=\"/>\n        <SerialHash
+    Value=\"2033b8ac3e6faa3742ca9f0bfae44d18f2a96b80\"/>\n        <Features>\n            <Feature
+    Value=\"33\"/>\n            <Feature Value=\"1\"/>\n            <Feature Value=\"12\"/>\n            <Feature
+    Value=\"2\"/>\n            <Feature Value=\"24\"/>\n            <Feature Value=\"3\"/>\n            <Feature
+    Value=\"36\"/>\n            <Feature Value=\"17\"/>\n            <Feature Value=\"19\"/>\n            <Feature
+    Value=\"62\"/>\n        </Features>\n        <DeveloperData
+    Value=\"AQAAAEY0LUJHUlgtWEQ0RS1aQ1dWLUM1SlctR0RIQg==\"/>\n        <SerialMasked
+    Value=\"F4-BGRX-XD4E-ZCWV-C5JW-XXXX\"/>\n        <StartDate Value=\"2021-02-08T00:00:00\"/>\n        <UpdateDate
+    Value=\"2021-02-09T00:34:57\"/>\n        <InitialActivationDate
+    Value=\"2021-02-08T00:34:56\"/>\n        <LicenseVersion Value=\"6.x\"/>\n        <ClientProvidedVersion
+    Value=\"2018.4.30f1\"/>\n        <AlwaysOnline Value=\"false\"/>\n        <Entitlements>\n            <Entitlement
+    Ns=\"unity_editor\" Tag=\"UnityPersonal\" Type=\"EDITOR\"
+    ValidTo=\"9999-12-31T00:00:00\"/>\n            <Entitlement Ns=\"unity_editor\" Tag=\"DarkSkin\"
+    Type=\"EDITOR_FEATURE\" ValidTo=\"9999-12-31T00:00:00\"/>\n        </Entitlements>\n    </License>\n<Signature
+    xmlns=\"http://www.w3.org/2000/09/xmldsig#\"><SignedInfo><CanonicalizationMethod
+    Algorithm=\"http://www.w3.org/TR/2001/REC-xml-c14n-20010315#WithComments\"/><SignatureMethod
+    Algorithm=\"http://www.w3.org/2000/09/xmldsig#rsa-sha1\"/><Reference URI=\"#Terms\"><Transforms><Transform
+    Algorithm=\"http://www.w3.org/2000/09/xmldsig#enveloped-signature\"/></Transforms><DigestMethod
+    Algorithm=\"http://www.w3.org/2000/09/xmldsig#sha1\"/><DigestValue>m0Db8UK+ktnOLJBtHybkfetpcKo=</DigestValue></Reference></SignedInfo><SignatureValue>o/pUbSQAukz7+ZYAWhnA0AJbIlyyCPL7bKVEM2lVqbrXt7cyey+umkCXamuOgsWPVUKBMkXtMH8L\n5etLmD0getWIhTGhzOnDCk+gtIPfL4jMo9tkEuOCROQAXCci23VFscKcrkB+3X6h4wEOtA2APhOY\nB+wvC794o8/82ffjP79aVAi57rp3Wmzx+9pe9yMwoJuljAy2sc2tIMgdQGWVmOGBpQm3JqsidyzI\nJWG2kjnc7pDXK9pwYzXoKiqUqqrut90d+kQqRyv7MSZXR50HFqD/LI69h68b7P8Bjo3bPXOhNXGR\n9YCoemH6EkfCJxp2gIjzjWW+l2Hj2EsFQi8YXw==</SignatureValue></Signature></root>"


Looks like this was differently formatted. I don't know what happened, but this might fail the build-tests pipelines after merging.

frostebite commented Sep 28, 2022

View reviewed changes

src/model/image-tag.ts Outdated Show resolved Hide resolved

frostebite changed the title ~~Cloud runner develop~~ Cloud Runner Develop - Pre-1.0 Cleanup Sep 28, 2022

frostebite requested review from GabLeRoux, davidmfinol and webbertakken September 28, 2022 09:16

frostebite changed the title ~~Cloud Runner Develop - Pre-1.0 Cleanup~~ Cloud Runner Develop - Pre-1.0 Foundation (cleanup and refactorings to prepare for 1.0) Sep 28, 2022

frostebite marked this pull request as ready for review September 28, 2022 09:19

frostebite marked this pull request as draft September 29, 2022 19:00

frostebite marked this pull request as ready for review September 30, 2022 23:32

frostebite assigned webbertakken and frostebite Oct 2, 2022

frostebite added the cloud-runner label Oct 2, 2022

frostebite mentioned this pull request Oct 4, 2022

AWS Fargate S3 Bucket name issue #270

Closed

frostebite marked this pull request as draft October 6, 2022 19:42

frostebite changed the title ~~Cloud Runner Develop - Pre-1.0 Foundation (cleanup and refactorings to prepare for 1.0)~~ Cloud Runner Develop - 1.0 Oct 6, 2022

frostebite added 12 commits October 13, 2022 15:42

Custom step file support

f0723ff

Custom step file support

0809b30

Custom step file support

8214abc

Custom step file support

61a036f

Custom step file support

6f985fa

Custom step file support

3a2aeda

Custom step file support

1e2679d

Prebuilt steps

4c4e25f

Prebuilt steps

29d9bdf

Cleanup tree usage

f910078

AWS upload step

a375130

AWS upload step implemented in cloud runner pipeline

d7a17bb

frostebite added 26 commits November 2, 2022 21:58

test retain workspace first

9aaaac9

fix integration test: locking

3ea2f18

fix integration test: locking

66639bf

fix integration test: locking

2b5fb5e

cleanup & retained mode test for k8s and aws

596e772

cleanup & retained mode test for k8s and aws

1df0148

cleanup & retained mode test for k8s and aws

59b4121

cleanup & retained mode test for k8s and aws

cade9e8

cleanup & retained mode test for k8s and aws

f63c2fe

cleanup & retained mode test for k8s and aws

6739f62

cleanup & retained mode test for k8s and aws

1e34c6f

cleanup & retained mode test for k8s and aws

ac53014

cleanup & retained mode test for k8s and aws

bf1ef14

cleanup & retained mode test for k8s and aws

f03fe8b

cleanup & retained mode test for k8s and aws

b710053

cleanup & retained mode test for k8s and aws

bb8c1d5

cleanup & retained mode test for k8s and aws

9a628a8

cleanup & retained mode test for k8s and aws

836a924

cleanup & retained mode test for k8s and aws

4eaa57b

fix logstream error k8s

d570e8b

fix logstream error k8s

239c747

always run -m list-resources after builds, will become always garbage…

4cbf5cf

… collect

always run -m list-resources after builds, will become always garbage…

d13f919

… collect

always run -m list-resources after builds, will become always garbage…

2df2662

… collect

rmv inspect cli, implement k8s list logging

cc3f984

merge main

7477337

frostebite marked this pull request as ready for review November 7, 2022 19:46

webbertakken approved these changes Nov 7, 2022

View reviewed changes

frostebite merged commit 4cca069 into main Nov 7, 2022

frostebite deleted the cloud-runner-develop branch November 7, 2022 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Cloud Runner Develop - 1.0 R.C 1 #437

Cloud Runner Develop - 1.0 R.C 1 #437

Uh oh!

frostebite commented Sep 17, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2022

Uh oh!

codecov-commenter commented Sep 28, 2022 •

edited

Loading

Uh oh!

Uh oh!

frostebite commented Sep 28, 2022

Uh oh!

webbertakken Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Cloud Runner Develop - 1.0 R.C 1 #437

Cloud Runner Develop - 1.0 R.C 1 #437

Uh oh!

Conversation

frostebite commented Sep 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All 1.0 feature tasks here:

Some noteworthy improvements and refactorings

Checklist

Uh oh!

github-actions bot commented Sep 17, 2022

Uh oh!

codecov-commenter commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

frostebite commented Sep 28, 2022

Uh oh!

webbertakken Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

frostebite commented Sep 17, 2022 •

edited

Loading

codecov-commenter commented Sep 28, 2022 •

edited

Loading