Skip to content

perf: avoid building docker image #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 30, 2022
Merged

perf: avoid building docker image #365

merged 9 commits into from
Mar 30, 2022

Conversation

paulpach
Copy link
Contributor

@paulpach paulpach commented Mar 30, 2022 •
edited
Loading

mount the scripts using volume instead of building docker image with the scripts.

in my setup, (self hosted runner on fedora) the build step goes from 6:23 to 2:04

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)
  • Windows builds

@github-actions
Copy link

Cat Gif

webbertakken
webbertakken requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent performance fix!

@paulpach paulpach marked this pull request as ready for review March 30, 2022 23:02
@webbertakken webbertakken merged commit b72639a into game-ci:main Mar 30, 2022
@paulpach paulpach deleted the nobuild branch March 31, 2022 14:11
@paulpach paulpach mentioned this pull request Mar 31, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webbertakken webbertakken webbertakken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulpach @webbertakken