Skip to content

Conversation

mob-sakai
Copy link
Contributor

@mob-sakai mob-sakai commented Oct 9, 2025

Changes

  • unity-changeset@3.0.1 explicitly include graphql dependency.

Related Issues

Related PRs

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Summary by CodeRabbit

  • Chores
    • Dependency housekeeping: removed the GraphQL runtime dependency to reduce install size and minimize potential conflicts.
    • Updated unity-changeset to 3.0.1, bringing minor stability improvements and compatibility updates.
    • Expected impact: slightly faster installs and a smaller footprint; no changes to features, behavior, or public APIs.
    • No code modifications beyond dependency updates; end-user experience remains unchanged.

unity-changeset@3.0.0 did not explicitly include graphql dependency. (game-ci#749)
Copy link

github-actions bot commented Oct 9, 2025

Cat Gif

Copy link

coderabbitai bot commented Oct 9, 2025

📝 Walkthrough

Walkthrough

Removed the runtime dependency on graphql and bumped unity-changeset from ^3.0.0 to ^3.0.1 in package.json. No code changes or exported API modifications.

Changes

Cohort / File(s) Summary of changes
Dependencies update
package.json
Removed graphql dependency (^16.11.0). Updated unity-changeset from ^3.0.0 to ^3.0.1. No other dependency or devDependency changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

Suggested reviewers

  • webbertakken
  • GabLeRoux

Poem

A hop and a bump in the deps we keep,
Snipped out GraphQL with a tidy sweep.
unity-changeset nudged to point-oh-one,
Carrots aligned—review soon done.
Thump-thump! says the build, light on its feet. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely describes the main change—upgrading unity-changeset to v3.0.1 to include the GraphQL dependency—and follows a clear conventional commit style, accurately reflecting the core update for anyone scanning the history.
Description Check ✅ Passed The description fully adheres to the repository template by including all required sections—Changes, Related Issues, Related PRs, Successful Workflow Run Link, and a completed Checklist—with each section properly populated and workflows links provided, ensuring clarity and consistency.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2822af5 and 933e840.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

31-56: Double-check GraphQL usages before dropping the dependency.

dist contains bundled references to "graphql" and my repo search was inconclusive — confirm no source/runtime code requires it before removing the dependency. Run these from the repo root and only remove if all return no matches:

# search repo (exclude build artifacts)
rg -n --hidden -S "from\s+['\"]graphql['\"]" --glob '!dist/**' --glob '!node_modules/**' || true
rg -n --hidden -S "require\(\s*['\"]graphql['\"]\s*\)" --glob '!dist/**' --glob '!node_modules/**' || true
rg -n --hidden -S "\bgraphql\b" --glob '!dist/**' --glob '!node_modules/**' || true

# also check package/lock files for declared dependency
rg -n '"graphql"' package.json package-lock.json yarn.lock pnpm-lock.yaml || true

If these return no matches, removal is safe; otherwise restore the dependency or update callers.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.34%. Comparing base (2822af5) to head (933e840).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   38.34%   38.34%           
=======================================
  Files          78       78           
  Lines        3169     3169           
  Branches      663      663           
=======================================
  Hits         1215     1215           
  Misses       1809     1809           
  Partials      145      145           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@webbertakken webbertakken merged commit 6e0bf17 into game-ci:main Oct 9, 2025
6 checks passed
@mob-sakai mob-sakai deleted the fix/unity-changeset-3.0.1 branch October 9, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants