-
-
Notifications
You must be signed in to change notification settings - Fork 292
fix: XLTS versions on MacOS are not supported #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughDependency version update in package.json, increasing unity-changeset from ^3.0.1 to ^3.1.0. No code or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
dist/index.js
is excluded by!**/dist/**
dist/index.js.map
is excluded by!**/dist/**
,!**/*.map
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
package.json
(1 hunks)
"semver": "^7.5.2", | ||
"ts-md5": "^1.3.1", | ||
"unity-changeset": "^3.0.1", | ||
"unity-changeset": "^3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the lockfile to pull 3.1.0.
Bumping the semver range in package.json isn’t enough on its own—Yarn will keep resolving to the existing 3.0.1 pinned in yarn.lock. Please regenerate and commit the lockfile (or otherwise ensure the bundled unity-changeset
version actually moves to 3.1.0); without that, the XLTS fix never ships.
🤖 Prompt for AI Agents
In package.json around line 53, the semver was bumped to "unity-changeset":
"^3.1.0" but the lockfile still pins 3.0.1; regenerate and commit the updated
lockfile so Yarn actually resolves to 3.1.0. Run yarn install (or yarn upgrade
unity-changeset@^3.1.0), verify yarn.lock now contains 3.1.0, run tests/build,
and commit the updated yarn.lock (or the appropriate lockfile) alongside this
package.json change.
Changes
unity-changeset
to3.1.0
for XLTS versions on MacOS.getUnityChangeset
support XLTS versions.Related Issues
Related PRs
Successful Workflow Run Link
PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.
Checklist
code of conduct
in the documentation repo)
Summary by CodeRabbit