Use npm to start app inside the container #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building the containers feature, I was following Node's Docker best practices document, and it says:
This seemed like a good idea at the start, but I forgot an important point that was brought up to me: what if the app needs building/compiling?
So this PR fixes this issue, by changing the
CMD
section in the container creation, to start the app usingnpm run start
. This allows the user to setup the additional steps it's app might need to run.The readme was also updated to reflect this change.