Skip to content

Use npm to start app inside the container #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Use npm to start app inside the container #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74d794a
docker: change command to use npm
ggwadera Sep 11, 2020
2ebce08
update readme
ggwadera Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ app.get('/', (req, res) => {
app.listen(process.env.PORT || 8123);
```

7. Update the `main` field in `package.json` with the filename of your app entry point: `"main": "app.js"`
7. Update the `scripts` section in `package.json` with your app entry point command, under `start`: `"start": "node app.js"`
8. Run `git add .`
9. Run `git commit -m "Initial Commit"`
10. Run `git push origin master`
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/docker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const createContainer = async (
]
}
},
Cmd: ['node', '.']
Cmd: ['npm', 'run', 'start']
})
.then(container => container.id)
.catch(err => err)
Expand Down