Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #20

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations #20

merged 1 commit into from
Nov 29, 2022

Conversation

dimitar-kostadinov
Copy link
Contributor

What this PR does / why we need it:
Cleanup scheduler.alpha.kubernetes.io/critical-pod annotations

Which issue(s) this PR fixes:
Fixes #kubernetes/kubernetes#79548

Special notes for your reviewer:

Release note:

scheduler.alpha.kubernetes.io/critical-pod annotation is removed as pod priority (spec.priorityClassName) is used instead to mark pods as critical

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 14, 2022
@dimitar-kostadinov dimitar-kostadinov marked this pull request as ready for review November 14, 2022 13:07
ScheererJ
ScheererJ approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Nov 29, 2022
@ScheererJ ScheererJ merged commit 8497e34 into gardener:master Nov 29, 2022
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@DockToFuture DockToFuture Awaiting requested review from DockToFuture DockToFuture is a code owner

@marwinski marwinski Awaiting requested review from marwinski marwinski is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimitar-kostadinov @ScheererJ @gardener-robot-ci-1 @gardener-robot