-
Notifications
You must be signed in to change notification settings - Fork 14
auto-require all gems #5
Conversation
I was excited to see this! But, after checking it out, I saw that it makes Base.new take 35 seconds on my machine and emit a bunch of warnings along the way:
Though it's just a joke project, I do want base to be fast enough to be easily imported and played with. :) Any ideas? |
The blacklisting thing worries me as well. If some gems had to be blacklisted, there are probably a thousand more that would break but didn't happen to be installed when @jwilkins wrote the patch... |
Perhaps we should automatically install all gems as dependencies of Base. |
|
I added the blacklist because eventmachine caused a segfault. @dkubb, dm-do-adapter loaded eventmachine, so that's why it was added, I think I got overzealous with dm-sqlite-adapter. However, I started to dig into the problem and realized that eventmachine had just gotten screwed up on my system. Not quite certain how, but after a fresh install of eventmachine, it all seems fine. I'll push a new version in a moment. |
@jwilkins weird that dm-do-adapter would load eventmachine. There's no dependency on it, and it's not referenced anywhere in the Gemfile, gemspec or lib afaik. |
I'm still skeptical—a 30 second startup time is punishing. :( |
Can it be paralellized? ;) |
How fast do you want it to be? I could: threadify it, only add from a whitelist of common gems that don't add too much to startup, only add X gems (randomly, first X). Something else? |
I kind of like the idea of requiring everything; it's like a satirical version of Bundler. Maybe as a separate gem so it's not constrained? The name "everything" isn't currently taken... ;) |
Base.new.methods.count
=> 10692