-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[www/showcase] Placement of the "Visit Site" button on modals #6775
Comments
👍 I agree—that part of the design wasn't very well planned! A community member brought this up a while ago in #6098, too. There I followed up with a quick mockup of how a "realigned" header could look: #6098 (comment) The scope of the aforementioned issue is the "Site Showcase", however we also use the same design to display the detail page of a "Starter" in the "Starter Showcase". The "Starter" detail header has slightly different requirements ("Deploy to Netlify" button, and potentially a couple more) and I still need to consolidate those. |
Hey Berrak, forgot to update you on this: I posted a first stab at trying to consolidate header designs of site and starter showcase in #6710 (comment). Would love to hear your thoughts if you have the time! |
Late to the party, yep this is good to go … and already merged I see :/! Thanks @davad, that brings us much closer to #6710 (comment) and in line with what we do for the starter showcase detail view! 🙏 🤗 Closed via #9320. ✌️ |
The current placement of the "visit site" button makes it harder to read (because it is on top of the image)
This might be a better place with the rest of the buttons/links for Source etc?
@fk what do you think?
The text was updated successfully, but these errors were encountered: