Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www/showcase] Placement of the "Visit Site" button on modals #6775

Closed
berraknil opened this issue Jul 26, 2018 · 5 comments
Closed

[www/showcase] Placement of the "Visit Site" button on modals #6775

berraknil opened this issue Jul 26, 2018 · 5 comments

Comments

@berraknil
Copy link
Contributor

The current placement of the "visit site" button makes it harder to read (because it is on top of the image)

image

This might be a better place with the rest of the buttons/links for Source etc?

image

@fk what do you think?

@berraknil berraknil added this to the Weekly Sprint for the Site Showcase (July 24th) milestone Jul 26, 2018
@berraknil berraknil self-assigned this Jul 26, 2018
@berraknil berraknil changed the title [www/showcase] Placement of the visit site button on modals [www/showcase] Placement of the "Visit Site" button on modals Jul 26, 2018
@fk
Copy link
Contributor

fk commented Jul 26, 2018

👍 I agree—that part of the design wasn't very well planned!

A community member brought this up a while ago in #6098, too. There I followed up with a quick mockup of how a "realigned" header could look: #6098 (comment)

The scope of the aforementioned issue is the "Site Showcase", however we also use the same design to display the detail page of a "Starter" in the "Starter Showcase". The "Starter" detail header has slightly different requirements ("Deploy to Netlify" button, and potentially a couple more) and I still need to consolidate those.

@berraknil berraknil removed this from the Weekly Sprint for the Site Showcase (July 24th) milestone Jul 30, 2018
@fk
Copy link
Contributor

fk commented Aug 1, 2018

Hey Berrak, forgot to update you on this: I posted a first stab at trying to consolidate header designs of site and starter showcase in #6710 (comment). Would love to hear your thoughts if you have the time!

@berraknil berraknil removed their assignment Aug 30, 2018
@davad
Copy link
Contributor

davad commented Oct 23, 2018

I just submitted a PR (#9320) that moves the links above the screenshot. I didn't implement @fk's mockup, just moved the existing components.

@KyleAMathews
Copy link
Contributor

@davad thanks! @fk do you think this is "good enough" now?

@fk
Copy link
Contributor

fk commented Oct 23, 2018

Late to the party, yep this is good to go … and already merged I see :/!

Thanks @davad, that brings us much closer to #6710 (comment) and in line with what we do for the starter showcase detail view! 🙏 🤗

Closed via #9320. ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants