Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to update the link of babel #22331

Merged
merged 1 commit into from Mar 17, 2020
Merged

Minor fix to update the link of babel #22331

merged 1 commit into from Mar 17, 2020

Conversation

@ashiscs
Copy link
Contributor

ashiscs commented Mar 16, 2020

Previously it was pointing to = https://github.com/babel/babel/
Now, it's updated to = https://github.com/babel/babel/tree/master/packages

Previously it was pointing to = https://github.com/babel/babel/
Now, it's updated to = https://github.com/babel/babel/tree/master/packages
@ashiscs ashiscs requested a review from gatsbyjs/core as a code owner Mar 16, 2020
@ashiscs

This comment has been minimized.

Copy link
Contributor Author

ashiscs commented Mar 16, 2020

@pieh sir, @pvdz sir please review!!

Copy link
Member

snitin315 left a comment

I'm not sure if this is required (changing the CHANGELOG).

@ashiscs

This comment has been minimized.

Copy link
Contributor Author

ashiscs commented Mar 16, 2020

@snitin315 but we should be consistent with the link as because there we were talking about packages and for react it was pointing correctly but for babel it was not.
So, it seems corrcet to me to update it..

@pieh
pieh approved these changes Mar 17, 2020
Copy link
Contributor

pieh left a comment

Let's go for consistency. Thanks @ashiscs!

@pieh pieh merged commit 30b656a into gatsbyjs:master Mar 17, 2020
22 checks passed
22 checks passed
Cloud Tests
Details
Danger All good
Details
Peril All green. Jolly good show.
Details
TypoCheck No typos found
Details
build-test Workflow: build-test
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node8 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
@gatsbot

This comment has been minimized.

Copy link

gatsbot bot commented Mar 17, 2020

Holy buckets, @ashiscs — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.