feat(gatsby): drop SitePage inference and schema update #33319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: GraphQL
wardpeet
previously approved these changes
Sep 28, 2021
packages/gatsby/src/schema/__tests__/__snapshots__/rebuild-schema.js.snap
Show resolved
Hide resolved
pieh
reviewed
Sep 28, 2021
wardpeet
approved these changes
Sep 28, 2021
wardpeet
pushed a commit
to herecydev/gatsby
that referenced
this pull request
Oct 29, 2021
* feat(gatsby): drop SitePage inference and schema update * fix cli integration tests * add missing field to built-it SitePage type * update snapshots * correct link between nodes * infer -> dontInfer * trigger tests re-run * trigger tests re-run * Restore `assignChangedPages`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow-up for #33268. This PR removes schema-related logic that is now redundant. Namely, schema updating after
createPagesAPI. Since we don't infer page context anymore we can rely on internal typings forSitePageand don't need to update schema afterSitePagenodes are created.