starter library detail page design changes #8568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amberleyromo
changed the title
DSchau
approved these changes
Sep 27, 2018
www/src/views/starter/meta.js
Outdated
| @@ -0,0 +1,174 @@ | |||
| import presets, { colors } from "../../utils/presets" | |||
| import { /*typography, */ rhythm, options } from "../../utils/typography" | |||
|
|
||
| function showDate(dt) { | ||
| const date = new Date(dt) | ||
| return date.toLocaleDateString(`en-US`, { |
There was a problem hiding this comment.
Can we use the graphql date format function here and pass this in? Or not possible?
(not a big deal either way, just asking!)
There was a problem hiding this comment.
Possible! I haven't looked into why this was done this way, I just relocated what was already there for now. Good thought.
| @@ -5,6 +5,7 @@ import ReactJSIcon from "./react.svg" | |||
| import SegmentIcon from "./segment.svg" | |||
| import FormidableIcon from "./formidable.svg" | |||
| import FabricIcon from "./fabric.svg" | |||
| import NetlifyIcon from "./netlify.svg" | |||
There was a problem hiding this comment.
Completely unrelated to this PR, but we should look into making these React components (where SVG is valid) instead of this!
cc @fk
fk
approved these changes
Sep 28, 2018
* import React * remove unused imports
amberleyromo
force-pushed
the
6710-starter-showcase-header
branch
from
95dc3da to
6bc250d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7731.
Starter detail page design changes a la #6710. Also includes some rearranging to make it more readable/easier for others to contribute (split into components, prompted by handling the ordering).
@fk some things to be aware of