Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipop #143

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Multipop #143

merged 3 commits into from
Jul 12, 2023

Conversation

philipbg
Copy link
Contributor

Changed "MegaPop" to "MultiPop" as mentioned here: #120 (comment)

@gregorgorjanc
Copy link
Contributor

@philipbg @gaynorr looks ok - most changes are whitespace

@philipbg it would be good to mention this name change in the NEWS (or equivalent) file - I don't think anyone/many use this option at this stage, but good to document the change.

@philipbg
Copy link
Contributor Author

philipbg commented Jul 10, 2023

@gregorgorjanc I am not sure why so much whitespace changes came about. I didn't hit space or enter. I just did find and replace. It looks like NEWs is updated with new versions of ASR, so this change (along with others) might be documented when a new version is released? Is there a place to put new changes that haven't been packaged into a new version yet?

@gregorgorjanc
Copy link
Contributor

@philipbg whitespace changes likely came from RStudio defaults. I have the same settings;)

@philipbg NEWS file can be updated as we go along so that on the release you have it mostly done;)

@philipbg
Copy link
Contributor Author

@gregorgorjanc it must be a default for emacs/magit too then

@gaynorr gaynorr changed the base branch from master to devel July 12, 2023 11:38
@gaynorr
Copy link
Owner

gaynorr commented Jul 12, 2023

@philipbg The initial checks failed due to the Namespace file not reflecting the changes you made. I fixed this by deleting the Namespace file and reran roxygen2::roxygenize() to auto generate it again.

I typically run "clean and install" in the "build" tab of RStudio before submitting a branch. This should update the documentation and Namespace file. It also serves as a check that everything is working by running running the unit tests and examples. Note that I have the "Generate documentation with Roxygen" box ticked in the "Configure build tools" menu.

I do find that sometimes the Namespace and documentation doesn't get updated like it should. This usually results an error when running "Build". I suspect this issue comes from working on different computers with different RStudio options, but I haven't isolated the exact cause. The delete the Namespace file trick I used above usually resolves this.

@gaynorr gaynorr merged commit 012953f into gaynorr:devel Jul 12, 2023
@gregorgorjanc gregorgorjanc mentioned this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants