Merge ign-physics5 ➡️ main #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com> Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Merge ign-physics1 ➡️ ign-physics2
Signed-off-by: Louise Poubel <louise@openrobotics.org>
When loading a model from SDF, the moment of inertia matrix is currently applying any rotations in the //inertial/pose two times, since the rotations are applied explicitly, but they are already applied in math::Inertial::Moi. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 76.82% 76.81% -0.01%
==========================================
Files 128 128
Lines 5739 5737 -2
==========================================
- Hits 4409 4407 -2
Misses 1330 1330
Help us with your feedback. Take ten seconds to tell us how you rate us. |
mjcarroll
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-physics5➡️mainBranch comparision: main...ign-physics5
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)