Fix macOS test segfaults #1728
Merged
Fix macOS test segfaults #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde
approved these changes
Sep 22, 2022
scpeters
pushed a commit
that referenced
this pull request
Nov 4, 2022
The segfaults happen when components are registered by plugins and component creation is attempted after the plugin that registered the component has been unloaded and it's component storage object has become invalid. Including this header insures that all components are registered by the core library ahead of any plugin. This is a temporary solution. A better solution would be to keep track of all the plugins that have registered a component. When a plugin gets unloaded, we would unregister that component in the destructor (right before the plugin is unloaded), and check our list if there are other plugins that have registered the component. If so, we would register the component again, this time using the component storage object from a currently loaded plugin. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
8 tasks
scpeters
pushed a commit
that referenced
this pull request
Nov 4, 2022
The segfaults happen when components are registered by plugins and component creation is attempted after the plugin that registered the component has been unloaded and it's component storage object has become invalid. Including this header insures that all components are registered by the core library ahead of any plugin. This is a temporary solution. A better solution would be to keep track of all the plugins that have registered a component. When a plugin gets unloaded, we would unregister that component in the destructor (right before the plugin is unloaded), and check our list if there are other plugins that have registered the component. If so, we would register the component again, this time using the component storage object from a currently loaded plugin. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The segfaults happen when components are registered by plugins and component creation is attempted after the plugin that registered the component has been unloaded and it's component storage object has become invalid. Including this header insures that all components are registered by the core library ahead of any plugin.
This is a temporary solution. A better solution would be to keep track of all the plugins that have registered a component. When a plugin gets unloaded, we would unregister that component in the destructor (right before the plugin is unloaded), and check our list if there are other plugins that have registered the component. If so, we would register the component again, this time using the component storage object from a currently loaded plugin.
This is similar to #807 but has code to try to mitigate other issues. This PR targets
gz-sim7because the segfaults appear to be not flaky anymore in this branch.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.