Merge ign-gazebo3 ➡️ ign-gazebo6 #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usly (gazebosim#1962) The main reason that the Resource Spawner took a long time to load is that it tried to fetch the list of all available models on Fuel instead of just the selected owner. And it did that while blocking the Qt thread, so the user was unable to interact with the GUI while the model list was being fetched. The approach I've taken is to only fetch the list of models for the default owner ("openrobotics") and allow users to add/remove any owner they want. The fetching is also done in a separate thread so as to not block the GUI. --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Include gz/msgs.hh instead of ignition * Install components.hh to gz/sim Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
…ts on a topic (gazebosim#1994) * Working on marker topic Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fixed build Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fixed test Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Cleanup Signed-off-by: Nate Koenig <natekoenig@gmail.com> * codecheck Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com>
…in a `<world>` (gazebosim#1998) Signed-off-by: Henrique-BO <henrique.barrosoliveira@usp.br>
|
Does this require an upstream release? |
It does. I'll make one shortly. |
7 tasks
|
@osrf-jenkins run tests please |
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #2013 +/- ##
===============================================
- Coverage 65.38% 65.37% -0.02%
===============================================
Files 327 327
Lines 26993 27005 +12
===============================================
+ Hits 17649 17654 +5
- Misses 9344 9351 +7
|
|
Is the windows failure part of the homebrew proto upgrade issue? |
No, it's a test failure from a test that was added recently (in #1998). That PR targetted ign-gazebo3 which doesn't have windows CI. |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
I've updated the test in to because I've also updated the branch to contain the latest PR added to ign-gazebo6. |
nkoenig
approved these changes
Jun 16, 2023
|
The test failure on Ubuntu seems to also occur on the stable branch (https://build.osrfoundation.org/view/ign-fortress/job/ignition_gazebo-ci-ign-gazebo6-focal-amd64/178/) . The windows warnings are also (https://build.osrfoundation.org/view/ign-fortress/job/ign_gazebo-ign-6-win/177) even though they seem to disappear in newer builds. I think that's probably due to the workspace not being cleared (gazebo-tooling/release-tools#724 (comment)). Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo3➡️ign-gazebo6Branch comparison: ign-gazebo6...ign-gazebo3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)