Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit to run gz sim -g on Windows #2382

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 24, 2024

🦟 Bug fix

Fixes #2089 . Requires gazebosim/gz-rendering#992 .

Summary

Allow to launch gz sim -g on Windows, as it will work fine once gazebosim/gz-rendering#992 is merged and released.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@azeey azeey added the needs upstream release Blocked by a release of an upstream library label Apr 25, 2024
@traversaro
Copy link
Contributor Author

A release of gz-rendering with the required changes have been released: https://github.com/gazebosim/gz-rendering/releases/tag/gz-rendering8_8.2.0 .

@azeey
Copy link
Contributor

azeey commented Jun 26, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 26, 2024

update

✅ Branch has been successfully updated

@azeey azeey enabled auto-merge (squash) June 26, 2024 02:46
@azeey azeey merged commit 04a5e0d into gazebosim:gz-sim8 Jun 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz sim -g fails on Windows with error "wglMakeCurrent failed: The pixel format is invalid."
3 participants