Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for converting Any <-> ParamValue #260

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Conversation

mjcarroll
Copy link
Collaborator

🎉 New feature

Summary

Add support for converting between gz::msgs::Any and rcl_interfaces/msg/ParameterValue.

This is used in support of MBZIRC's RF ranging sensor: osrf/mbzirc#151 to avoid adding custom messages that won't be supported by the bridge.
Both of these types use a "tagged union" approach to represent multiple datatypes within a single message.

Currently, the supported types have overlap for the most common types, but aren't identical. When an unsupported type is converted, the resulting message will be unpopulated.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Jun 21, 2022
@mjcarroll mjcarroll requested a review from iche033 June 21, 2022 16:03
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@chapulina chapulina added the ROS 2 ROS 2 label Jun 21, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, uncrustify is unhappy though

ros_ign_bridge/ros_ign_bridge/mappings.py Outdated Show resolved Hide resolved
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit d25ae55 into galactic Jun 21, 2022
@mjcarroll mjcarroll deleted the bridge_any branch June 21, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ROS 2 ROS 2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants