Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gz.msgs.EntityWrench #572

Closed
wants to merge 12 commits into from
Closed

Conversation

Vtn21
Copy link
Contributor

@Vtn21 Vtn21 commented Jun 27, 2024

🎉 New feature

Closes #566

Summary

Adds the new ros_gz_interfaces/msg/EntityWrench, with structure compatible with gz.msgs.EntityWrench. This enables the user to apply wrenches to Gazebo entities using ROS topics.

Also implements the ros_gz_bridge mapping between ros_gz_interfaces/msg/EntityWrench and gz.msgs.EntityWrench.

Test it

Manual testing involves spawning any entity in Gazebo and loading the gz::sim::systems::ApplyLinkWrench plugin to the world SDF. Then, call the ros_gz_bridge to expose the entity wrench topic as follows (YAML syntax):

- topic_name: "/world/<world_name>/wrench"
  ros_type_name: "ros_gz_interfaces/msg/EntityWrench"
  gz_type_name: "gz.msgs.EntityWrench"

Wrenches are then applied to selected entities using the "/world/<world_name>/wrench" topic.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Victor T. N <victortn21@hotmail.com>
Signed-off-by: Victor T. N <victortn21@hotmail.com>
Signed-off-by: Victor T. N <victortn21@hotmail.com>
Signed-off-by: Victor T. N <victortn21@hotmail.com>
Signed-off-by: Victor T. N <victortn21@hotmail.com>
Signed-off-by: Victor T. N <victortn21@hotmail.com>
Signed-off-by: Victor T. N <victortn21@hotmail.com>
…Wrench

Signed-off-by: Victor T. N <victortn21@hotmail.com>
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you retarget the PR to rolling ? then we can backport this to other branches.

We use mergify to backport PR, there is no need to create a PR for each branch

@ahcorde ahcorde changed the base branch from iron to ros2 June 28, 2024 14:46
ros_gz_bridge/README.md Outdated Show resolved Hide resolved
Vtn21 and others added 3 commits June 28, 2024 14:49
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Victor T. N. <Vtn21@users.noreply.github.com>
| vision_msgs/msg/Detection3DArray | gz::msgs::AnnotatedOriented3DBox_V |
| ROS type | Gazebo type |
|---------------------------------------------|:-------------------------------------------:|
| builtin_interfaces/msg/Time | gz::msgs::Time |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only this one, the rest of item too

@Vtn21
Copy link
Contributor Author

Vtn21 commented Jun 29, 2024

Hi @ahcorde , sorry for my delay. While working on merging the PR with the base ros2 branch, I ended up forgetting to signoff a commit and things got messy. I opened another PR checking out directly from the ros2 branch which I believe is better now. Thanks for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ros_gz_bridge support for gz.msgs.EntityWrench
2 participants