Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gz.msgs.EntityWrench (base branch: ros2) #573

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

Vtn21
Copy link
Contributor

@Vtn21 Vtn21 commented Jun 29, 2024

🎉 New feature

Closes #566

Also replaces PR #572, now retargeted to the ros2 branch.

Summary

Adds the new ros_gz_interfaces/msg/EntityWrench, with structure compatible with gz.msgs.EntityWrench. This enables the user to apply wrenches to Gazebo entities using ROS topics.

Also implements the ros_gz_bridge mapping between ros_gz_interfaces/msg/EntityWrench and gz.msgs.EntityWrench.

Test it

Manual testing involves spawning any entity in Gazebo and loading the gz::sim::systems::ApplyLinkWrench plugin to the world SDF. Then, call the ros_gz_bridge to expose the entity wrench topic as follows (YAML syntax):

- topic_name: "/world/<world_name>/wrench"
  ros_type_name: "ros_gz_interfaces/msg/EntityWrench"
  gz_type_name: "gz.msgs.EntityWrench"

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
@Vtn21 Vtn21 requested a review from ahcorde as a code owner June 29, 2024 15:54
@ahcorde ahcorde merged commit f9afb69 into gazebosim:ros2 Jul 1, 2024
4 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Jul 1, 2024

https://github.com/Mergifyio backport jazzy humble iron

Copy link
Contributor

mergify bot commented Jul 1, 2024

backport jazzy humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 1, 2024
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
(cherry picked from commit f9afb69)
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
(cherry picked from commit f9afb69)

# Conflicts:
#	ros_gz_bridge/README.md
#	ros_gz_bridge/test/utils/gz_test_msg.hpp
mergify bot pushed a commit that referenced this pull request Jul 1, 2024
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
(cherry picked from commit f9afb69)

# Conflicts:
#	ros_gz_bridge/README.md
#	ros_gz_bridge/test/utils/gz_test_msg.hpp
ahcorde added a commit that referenced this pull request Jul 1, 2024
…) (#576)

* Add support for gz.msgs.EntityWrench (base branch: ros2) (#573)

Signed-off-by: Victor T. N. <victortn21@hotmail.com>
(cherry picked from commit f9afb69)

# Conflicts:
#	ros_gz_bridge/README.md
#	ros_gz_bridge/test/utils/gz_test_msg.hpp

* Fixed merge

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Victor T. Noppeney <Vtn21@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jul 9, 2024
…) (#575)

* Add support for gz.msgs.EntityWrench (base branch: ros2) (#573)

Signed-off-by: Victor T. N. <victortn21@hotmail.com>
(cherry picked from commit f9afb69)

# Conflicts:
#	ros_gz_bridge/README.md
#	ros_gz_bridge/test/utils/gz_test_msg.hpp

* Fixed merge

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* Update ros_gz_bridge/README.md

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Victor T. Noppeney <Vtn21@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
(cherry picked from commit f9afb69)

Co-authored-by: Victor T. Noppeney <Vtn21@users.noreply.github.com>
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Sep 18, 2024
Signed-off-by: Victor T. N. <victortn21@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ros_gz_bridge support for gz.msgs.EntityWrench
2 participants