Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate inertia #1019

Merged
merged 3 commits into from
Jun 8, 2022
Merged

deprecate inertia #1019

merged 3 commits into from
Jun 8, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 13, 2022

🎉 New feature

Summary

Deprecated the Inertia class, which is not used in sdformat.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1019 (c3b7b9c) into main (f3457ef) will not change coverage.
The diff coverage is n/a.

❗ Current head c3b7b9c differs from pull request most recent head 7d6bc72. Consider uploading reports for the commit 7d6bc72 to get more accurate results

@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   83.64%   83.64%           
=======================================
  Files         146      146           
  Lines       18255    18255           
=======================================
  Hits        15269    15269           
  Misses       2986     2986           
Impacted Files Coverage Δ
include/sdf/Types.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3457ef...7d6bc72. Read the comment docs.

Migration.md Outdated Show resolved Hide resolved
Nate Koenig added 2 commits June 8, 2022 08:32
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig enabled auto-merge (squash) June 8, 2022 15:34
@nkoenig nkoenig merged commit 5f3031e into main Jun 8, 2022
@nkoenig nkoenig deleted the deprecate-inertia branch June 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants