Use action-ignition-ci

[scpeters]

Revives #266.

Signed-off-by: Steve Peters scpeters@openrobotics.org

[codecov-io]

Codecov Report

Merging #452 (e4b237f) into master (e0e09f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files          63       63           
  Lines        9622     9622           
=======================================
  Hits         8432     8432           
  Misses       1190     1190           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e09f9...e4b237f. Read the comment docs.

[chapulina]

LGTM. I see the code checker has some errors that aren't causing the build to fail:

  [src/ScopedGraph.hh:85]: (error) syntax error
  [src/ScopedGraph.hh:85]: (error) syntax error
  [src/Utils.cc:79]: (style) The function 'isValidFrameReference' is never used.
  [src/Types.cc:83]: (style) The function 'operator<<' is never used.

I think that's probably something to be fixed in code_check.sh.

We could probably also add Focal CI, that's just using the focal branch of the action.

[chapulina]

I'm curious about the long-term plan, are we going to keep the action defined here?

https://github.com/osrf/sdformat/blob/master/.github/workflows/linux-ubuntu-bionic.yml

[scpeters]

I'm curious about the long-term plan, are we going to keep the action defined here?

https://github.com/osrf/sdformat/blob/master/.github/workflows/linux-ubuntu-bionic.yml

I think we can delete that workflow. I'll get back to it for sure next week when I return from vacation; otherwise someone else can take this over

[scpeters]

We could probably also add Focal CI, that's just using the focal branch of the action.

👍