Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Surface Python interface #940

Merged
merged 8 commits into from
Apr 14, 2022
Merged

Added Surface Python interface #940

merged 8 commits into from
Apr 14, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 6, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this meta ticket #931

Summary

Added Surface Python interface

Test it

from sdformat import Surface, Contact

surface = Surface()
contact = Contact()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 6, 2022
@ahcorde ahcorde self-assigned this Apr 6, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #940 (9bbc9e5) into main (66c1609) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   87.99%   87.94%   -0.05%     
==========================================
  Files         106      107       +1     
  Lines       14826    14859      +33     
==========================================
+ Hits        13046    13068      +22     
- Misses       1780     1791      +11     
Impacted Files Coverage Δ
python/src/sdf/pySurface.cc 64.51% <64.51%> (ø)
python/src/sdf/_ignition_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c1609...9bbc9e5. Read the comment docs.

@scpeters scpeters enabled auto-merge (squash) April 14, 2022 19:39
@scpeters scpeters merged commit 24e6180 into main Apr 14, 2022
@scpeters scpeters deleted the ahcorde/python/surface branch April 14, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants