Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Collision Python interface #949

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Added Collision Python interface #949

merged 3 commits into from
Apr 19, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 7, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this meta ticket #931

Require:

Summary

Added Collision Python interface

Test it

from sdformat import Collision

collision = Collision()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 7, 2022
@ahcorde ahcorde self-assigned this Apr 7, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 7, 2022
@ahcorde ahcorde marked this pull request as ready for review April 19, 2022 20:59
@codecov-commenter
Copy link

Codecov Report

Merging #949 (d40ab5b) into main (f06aca4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06aca4...d40ab5b. Read the comment docs.

@scpeters scpeters merged commit bb84733 into main Apr 19, 2022
@scpeters scpeters deleted the ahcorde/python/collision branch April 19, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants