Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sensor Python interface #988

Merged
merged 4 commits into from
May 23, 2022
Merged

Added Sensor Python interface #988

merged 4 commits into from
May 23, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 18, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this mete ticket #931

Require

Summary

Added Sensor Python interface

Test it

from sdformat import Sensor

sensor = Sensor()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added scripting Scripting interfaces to Ignition mujoco labels Apr 18, 2022
@ahcorde ahcorde self-assigned this Apr 18, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 18, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 18, 2022
@ahcorde ahcorde mentioned this pull request Apr 18, 2022
62 tasks
@chapulina chapulina moved this from Inbox to In progress in Core development Apr 22, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
@j-rivero j-rivero removed this from In progress in Core development May 6, 2022
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting and documentation issues. Otherwise, LGTM!

python/src/sdf/pySensor.cc Outdated Show resolved Hide resolved
python/src/sdf/pySensor.cc Outdated Show resolved Hide resolved
python/src/sdf/pySensor.cc Show resolved Hide resolved
python/test/pySensor_TEST.py Outdated Show resolved Hide resolved
python/test/pySensor_TEST.py Outdated Show resolved Hide resolved
@ahcorde ahcorde marked this pull request as ready for review May 23, 2022 13:25
@ahcorde ahcorde requested a review from scpeters as a code owner May 23, 2022 13:25
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #988 (9c31ba0) into main (0726b68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #988   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0726b68...9c31ba0. Read the comment docs.

@ahcorde ahcorde merged commit e18a43f into main May 23, 2022
@ahcorde ahcorde deleted the ahcorde/python/sensor branch May 23, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants