Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Noise Python interface #969

Merged
merged 6 commits into from
Apr 19, 2022
Merged

Added Noise Python interface #969

merged 6 commits into from
Apr 19, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 12, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Noise Python interface

Test it

from sdformat import Noise

noise = Noise()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 12, 2022
@ahcorde ahcorde self-assigned this Apr 12, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #969 (bf73efc) into main (0494785) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0494785...bf73efc. Read the comment docs.

ahcorde and others added 2 commits April 15, 2022 18:38
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about deepcopy. Otherwise, LGTM!

FYI, I've fixed a couple of typos in 1d643f8.

python/test/pyNoise_TEST.py Outdated Show resolved Hide resolved
python/test/pyNoise_TEST.py Show resolved Hide resolved
@ahcorde ahcorde requested a review from azeey April 18, 2022 08:18
@ahcorde ahcorde merged commit 2ac7704 into main Apr 19, 2022
@ahcorde ahcorde deleted the ahcorde/python/noise branch April 19, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants