Skip to content

Clarifications to the explanation of interrupts #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Clarifications to the explanation of interrupts #417

merged 4 commits into from
Jun 9, 2022

Conversation

ihonen
Copy link
Contributor

@ihonen ihonen commented Jun 8, 2022

I noticed that some of the language used in the explanation of interrupts was vague and not technically entirely correct, so I thought I'd contribute a revision.

For example:

  • an interrupt is not executed, it is serviced
  • the interrupt vector is not the same thing as the interrupt handler
  • etc.

Mostly rather insignificant, I know, but I couldn't help my pedantic self.

Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I really like the "execution -> servicing" change.

Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is much better.

avivace and others added 2 commits June 9, 2022 21:41
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
@avivace avivace merged commit e55c55c into gbdev:master Jun 9, 2022
@ihonen
Copy link
Contributor Author

ihonen commented Jun 12, 2022

A bit late with my response, but glad you liked it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants