Attempt to fix broken WRAM bank hyperlink #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, there's also a commit that switches from “single-speed” to “normal-speed”, which seems unintended. I can remove that commit myself if you'd like me to? |
|
That one was already merged you can remove it.
…On Wed, Sep 10, 2025, 4:30 PM Eldred Habert ***@***.***> wrote:
*ISSOtm* left a comment (gbdev/pandocs#622)
<#622 (comment)>
Hmm, there's also a commit that switches from “single-speed” to
“normal-speed”, which seems unintended. I can remove that commit myself if
you'd like me to?
—
Reply to this email directly, view it on GitHub
<#622 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGDS4UHI2LAJMSUSLYPXYPL3SCC5FAVCNFSM6AAAAACGFNZDWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENZWGQYDIOBRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Confirmed, but strange that it still showed as a change in the UI. Ah well. |
ISSOtm
approved these changes
Sep 10, 2025
GitHub UI often struggles with force-pushed rebases - normally takes a while to update (if at all) |
avivace
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621
Remember, I'm still not setup to generate the HTML and check if this fix succeeded myself.