gh-2580 remove dynamic schema. #2870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t11947
reviewed
Jan 25, 2023
Comment on lines
146
to
147
| ((OperationView) resultOp).setView(validView); | ||
| // Deprecated function still in use due to Federated GetTraits bug with DYNAMIC_SCHEMA |
There was a problem hiding this comment.
Suggested change
| ((OperationView) resultOp).setView(validView); | |
| // Deprecated function still in use due to Federated GetTraits bug with DYNAMIC_SCHEMA | |
| ((OperationView) resultOp).setView(validView); |
t11947
suggested changes
Jan 25, 2023
t92549
reviewed
Feb 20, 2023
| @@ -101,10 +100,7 @@ protected void validateViews(final Operation op, final User user, final Store st | |||
| if (graphIdValid) { | |||
| currentResult = new ValidationResult(); | |||
| clonedOp.graphIdsCSV(graphId); | |||
| // Deprecated function still in use due to Federated GetTraits bug with DYNAMIC_SCHEMA | |||
| if (!graphSerialisable.getGraph().getStoreTraits().contains(StoreTrait.DYNAMIC_SCHEMA)) { | |||
There was a problem hiding this comment.
This only used to run on proxy stores and federated stores but now on all, is this okay?
There was a problem hiding this comment.
"Not (Traits contains Dynamic Schema)"
|
superseded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue