-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FederatedStore checks for DYNAMIC_SCHEMA #2580
Comments
The fix for this has to be smarter than just checking if the FederatedStore is assignable from the store in question, because it can also be valid for ProxyStores pointing to FederatedStores |
Needs investigation to decide if this needs to stay in alpha5 or move to post V2. Might just result in code being deleted if it's not required |
This will link in with #2581 |
…chema-removal # Conflicts: # store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/FederatedOperationChainValidator.java
…t schema because Store.initialise() doesn't set original schema.
…s compact schema because Store.initialise() doesn't set original schema.
…-2580-fix-federatedstore-checks-for-DYNAMIC_SCHEMA
* Remove DYNAMIC_SCHEMA Trait and usages * Re-enable disabled test in Federated Store
Closed by #2915 The solution for this was to remove the |
Due to a partial implementation of #2008, currently FederatedOperationChains only validate the View if the graph does not have the
DYNAMIC_SCHEMA
trait:Gaffer/store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/operation/FederatedOperationChainValidator.java
Line 82 in 40bb337
Gaffer/store-implementation/federated-store/src/main/java/uk/gov/gchq/gaffer/federatedstore/util/FederatedStoreUtil.java
Line 134 in 40bb337
This trait only exists in the FederatedStore as its getTraits() implementation returns ALL_TRAITS. This effectively means that only FederatedStores and ProxyStores which point to a FederatedStore will not be validated here. However, this cannot be used going forward because:
Therefore, before the getTraits/getStoreTraits function can be completely removed, this usage has to be replaced (under this ticket). This can be done in various ways:
A solution to this must be discussed, decided on and implemented before getTraits can be completely removed and it seems that it will be best to wait until the other FederatedStore changes first to do so.
The text was updated successfully, but these errors were encountered: