Gh-3250: GetElementsWithinSet bug fix #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3251 +/- ##
==========================================
Coverage 67.27% 67.28%
Complexity 2572 2572
==========================================
Files 926 926
Lines 29734 29738 +4
Branches 3290 3290
==========================================
+ Hits 20005 20009 +4
Misses 8282 8282
Partials 1447 1447 ☔ View full report in Codecov by Sentry. |
tb06904
reviewed
Jul 17, 2024
.../src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreGetElementsWithinSetTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/uk/gov/gchq/gaffer/federatedstore/FederatedStoreGetElementsWithinSetTest.java
Outdated
Show resolved
Hide resolved
p29876
approved these changes
Jul 17, 2024
tb06904
approved these changes
Jul 17, 2024
|
wb36499
added a commit
that referenced
this pull request
Aug 13, 2024
* prepare for next development iteration * prepare for next development iteration * prepare for next development iteration * Gh-3244 fix ci versioning (#3245) * move to revision property * update ci * update ignore * Gh-3085 Fix payloadOperation being exposed by getOperations (#3247) * Gh-3085 Fix payloadOperation being exposed by getOperations * headers * add test * Gh-3220: Standardise GafferPop Tests (#3243) * update graph IT tests * Rename GraphIT -> GraphTest * create graph IT * Create Modern Federated example graph run graph tests on multiple graph types * Update federated IT tests move non-federates specific tests to graph tests * tidying * remove public + spotless * sonarcloud * sonarcloud * Use allEdges/allEntities * tidy --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3237 Implement DeleteElements for Map Store (#3239) * Gh-3237 Implement DeleteElements for Map Store * remove unused param * spotless * codecov and sonarcloud * improve codecov and sonarcloud * reduce test duplication and add to federated store * checkstyle * remove unused properties and improve check * address PR comments and improve tests * fix indent * checkstyle * copyright * bump version * address comments * add comment --------- Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com> * Gh-3238: target delete accumulo (#3249) * Gh-3237 Implement DeleteElements for Map Store * remove unused param * spotless * wip * finish * checkstyle * codecov and sonarcloud * improve codecov and sonarcloud * reduce test duplication and add to federated store * checkstyle * remove unused properties and improve check * Gh-3238 Implement DeleteElements for Accumulo * add accumulo test to federated store * remove commented test * address comments * address comments * checkstyle * checkstyle * headers * code cov * remove public * remove AccumuloClient * code cov * checkystle * add test --------- Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> * Gh-3246: Add an explain step and GafferPop to REST API (#3248) * basic rest controller for gremlin * basic websocket endpoint for gremlin inside the rest api * improvements to the gremlin ws endpoint * basic hooks for storing last chain * Add working explain endpoint and tidy websocket * Add open telementry reporting * overhaul gremlin user auth and move cypher translator * basic testing for gremlin controller * move to utils class * basic testing updates * update the options parsing and testing * test tweaks * updates from testing * tweaks * spotless * address comments --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3250: GetElementsWithinSet bug fix (#3251) * initial testing and changes * tidy up, remove bug test and copyright headers * fix commented out lines * additional federated tests * reduce duplicate tests * checkstyle * add inOutType * copyright * fix version variable * address comments --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3253 Fix custom types in gremlin (#3255) * add conversions so gafferpop edges and vertexes are graphson compliant * update testing * update testing * javadoc * make sure cypher types can be used correctly * typo * Gh-3259: Improve release process (#3260) * update release pipelines * simplify * release notes fix * remove comment * address comments * Make gremlin config message clearer (#3264) * Gh-3258: Sonarcloud Issues (#3261) * initial improvements * more test tidy up * more fixes * improve coverage * copyright * fix DeleteAllData test * checkstyle * address comments * address comments * checkstyle * checkstyle --------- Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * Gh-3254: Standardise Spring REST user authentication (#3263) * remove unnecessary controller interfaces and add http header setting * test tweaks * Update rest-api/spring-rest/src/main/java/uk/gov/gchq/gaffer/rest/controller/JobController.java Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> --------- Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com> Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> * prepare release gaffer2-2.3.0 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: tb06904 <141412860+tb06904@users.noreply.github.com> Co-authored-by: p29876 <165825455+p29876@users.noreply.github.com> Co-authored-by: wb36499 <166839644+wb36499@users.noreply.github.com> Co-authored-by: cn337131 <141730190+cn337131@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetElementsWithinSet did not implement the SeededGraphFilters interface which was leading to edges getting lost when the number of entries for the batch scanner was less than the input size as the range was defaulting to outgoing edges only. This is fixed by implementing the interface, this is also in-line with all other Accumulo specific operations.
Related issue