Repository navigation
taxify 0.5.1
Fixed
add_trait() no longer returns NA for every source past a batch size (#55).
The per-name-set memos behind hybrid-parent resolution and cross-backbone name
recovery were keyed on the query set itself, held as a variable in the session
environment. R caps the name of a variable in an environment at 10000 bytes, and
reading past that cap raises rather than missing -- so once a batch resolved
enough names, the cache read took the whole join down with it and every source
came back all-NA.
Because the cap is on total bytes, the batch size that tripped it moved with how
many names the backbone resolved and how long they were. That is why a large
call could come back with one source populated and the rest empty, and read as a
coverage result rather than a failure.
Both memos now use a session store that carries keys of any length.
Reporting
-
A trait source that cannot be joined is named in a warning whether or not
verbose = TRUE. Such a source leaves an all-NAcolumn, which reads exactly
like the source genuinely holding nothing for those taxa, so silence there
turns a failure into a coverage statement. -
add_trait(verbose = TRUE)reports what each source supplied against the
number of names the backbone resolved:add_trait('dispersal_syndrome'): gift 152, austraits 40, leda 281, baseflor 336, brot 0 (of 2400 resolved names).
Thanks to @gcol33 for the report and the reproducible test case.