Added quiality-of-life improvements #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for screen clear for non-UNIX systems, exit codes for various errors, and uses UNIX time instead of datetime.
ayushkumar0208
approved these changes
Sep 27, 2020
bupboi1337
approved these changes
Nov 9, 2021
| @@ -71,10 +71,11 @@ Open up an text editor, copy & paste the code below. Save the file as: | |||
| import socket | |||
There was a problem hiding this comment.
Make sure to list the requirements in a txt file.
|
|
||
| # Checking the time again | ||
| t2 = datetime.now() | ||
| t2 = time() | ||
|
|
||
| # Calculates the difference of time, to see how long it took to run the script | ||
| total = t2 - t1 |
There was a problem hiding this comment.
Replace total with runtime for extra readability or t3 for smaller file size
| @@ -71,10 +71,11 @@ Open up an text editor, copy & paste the code below. Save the file as: | |||
| import socket | |||
| import subprocess | |||
| import sys | |||
| from datetime import datetime | |||
| from time import time | |||
There was a problem hiding this comment.
Why time instead of datetime?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for screen clear for non-UNIX systems, exit codes for various errors, and uses UNIX time instead of datetime.