Skip to content

Conversation

Codes-Talent
Copy link
Contributor

No description provided.

@unnown
Copy link

unnown commented Oct 2, 2020

Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest)
This will also ban the user for trying to abuse the system by doing marginal effort

@@ -0,0 +1,69 @@
from _datetime import datetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper documentation is not done.
Which makes the purpose of the program less clear.

from tkinter import ttk
from _datetime import *

win = tk.Tk()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Object Oriented Programming practices would have been implemented it would have been much better.
Use function and if necessary classes to do the work.
It is a very unprofessional way of writing the program as a plain script.




############################################ Label on Frame ############################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the standard practices of python programming language.


date = ttk.Label(frame,text = 'Date : ',font = ('',12,'bold'))
date.grid(row=3,column=0,sticky = tk.W)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is extremely important, which is missing.

Also avoid magic numbers.

@geekcomputers geekcomputers merged commit a97d18a into geekcomputers:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants