-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Improve Docs #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docs #942
Conversation
Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest) |
@@ -0,0 +1,69 @@ | |||
from _datetime import datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proper documentation is not done.
Which makes the purpose of the program less clear.
from tkinter import ttk | ||
from _datetime import * | ||
|
||
win = tk.Tk() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Object Oriented Programming practices would have been implemented it would have been much better.
Use function and if necessary classes to do the work.
It is a very unprofessional way of writing the program as a plain script.
|
||
|
||
|
||
############################################ Label on Frame ############################################ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the standard practices of python programming language.
|
||
date = ttk.Label(frame,text = 'Date : ',font = ('',12,'bold')) | ||
date.grid(row=3,column=0,sticky = tk.W) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is extremely important, which is missing.
No description provided.